FreeBSD support

[jbeich]

Depends on intel/libva#363 and intel/gmmlib#68

Build logs

http://beefy9.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/21.1.1/114amd64-default.log
http://beefy10.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/21.1.1/114i386-default.log
http://beefy6.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/21.1.1/122amd64-default.log
http://beefy5.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/21.1.1/122i386-default.log
http://beefy18.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/21.1.1/main-amd64-default.log
http://beefy17.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/21.1.1/main-i386-default.log
https://sting.dragonflybsd.org/dports/logs/multimedia___libva-intel-media-driver.log

Tests output

[==========] Running 43 tests from 13 test cases.
[----------] Global test environment set-up.
[----------] 1 test from MediaCapsDdiTest
[ RUN      ] MediaCapsDdiTest.DecodeEncodeProfile
[       OK ] MediaCapsDdiTest.DecodeEncodeProfile (11 ms)
[----------] 1 test from MediaCapsDdiTest (11 ms total)

[----------] 2 tests from MediaDecodeDdiTest
[ RUN      ] MediaDecodeDdiTest.DecodeHEVCLong
[       OK ] MediaDecodeDdiTest.DecodeHEVCLong (6 ms)
[ RUN      ] MediaDecodeDdiTest.DecodeAVCLong
[       OK ] MediaDecodeDdiTest.DecodeAVCLong (10 ms)
[----------] 2 tests from MediaDecodeDdiTest (16 ms total)

[----------] 2 tests from MediaEncodeDdiTest
[ RUN      ] MediaEncodeDdiTest.EncodeHEVC_DualPipe
[       OK ] MediaEncodeDdiTest.EncodeHEVC_DualPipe (10 ms)
[ RUN      ] MediaEncodeDdiTest.EncodeAVC_DualPipe
[       OK ] MediaEncodeDdiTest.EncodeAVC_DualPipe (12 ms)
[----------] 2 tests from MediaEncodeDdiTest (22 ms total)

[----------] 5 tests from KernelTest
[ RUN      ] KernelTest.LoadDestroyProgram
[       OK ] KernelTest.LoadDestroyProgram (67 ms)
[ RUN      ] KernelTest.LoadWrongIsa
[       OK ] KernelTest.LoadWrongIsa (13 ms)
[ RUN      ] KernelTest.CreateKernel
[       OK ] KernelTest.CreateKernel (26 ms)
[ RUN      ] KernelTest.SetArgument
[       OK ] KernelTest.SetArgument (78 ms)
[ RUN      ] KernelTest.SetSamplerBTI
[       OK ] KernelTest.SetSamplerBTI (67 ms)
[----------] 5 tests from KernelTest (251 ms total)

[----------] 3 tests from BufferTest
[ RUN      ] BufferTest.MultipleSizes
[       OK ] BufferTest.MultipleSizes (79 ms)
[ RUN      ] BufferTest.ReadWrite
[       OK ] BufferTest.ReadWrite (13 ms)
[ RUN      ] BufferTest.Initialization
[       OK ] BufferTest.Initialization (14 ms)
[----------] 3 tests from BufferTest (106 ms total)

[----------] 2 tests from BufferUPTest
[ RUN      ] BufferUPTest.MultipleSizes
[       OK ] BufferUPTest.MultipleSizes (79 ms)
[ RUN      ] BufferUPTest.InvalidSystemMemory
[       OK ] BufferUPTest.InvalidSystemMemory (28 ms)
[----------] 2 tests from BufferUPTest (107 ms total)

[----------] 8 tests from DeviceTest
[ RUN      ] DeviceTest.Destroy
[       OK ] DeviceTest.Destroy (13 ms)
[ RUN      ] DeviceTest.NoScratchSpace
[       OK ] DeviceTest.NoScratchSpace (18 ms)
[ RUN      ] DeviceTest.QueryGpuPlatform
[       OK ] DeviceTest.QueryGpuPlatform (14 ms)
[ RUN      ] DeviceTest.QueryThreadCount
[       OK ] DeviceTest.QueryThreadCount (13 ms)
[ RUN      ] DeviceTest.QueryFrequency
[       OK ] DeviceTest.QueryFrequency (13 ms)
[ RUN      ] DeviceTest.QueryPlatformInformation
[       OK ] DeviceTest.QueryPlatformInformation (13 ms)
[ RUN      ] DeviceTest.SetThreadCount
[       OK ] DeviceTest.SetThreadCount (13 ms)
[ RUN      ] DeviceTest.GetInvalidCap
[       OK ] DeviceTest.GetInvalidCap (13 ms)
[----------] 8 tests from DeviceTest (111 ms total)

[----------] 2 tests from QueueTest
[ RUN      ] QueueTest.CreateTwice
[       OK ] QueueTest.CreateTwice (14 ms)
[ RUN      ] QueueTest.EnqueueWithoutTask
[       OK ] QueueTest.EnqueueWithoutTask (13 ms)
[----------] 2 tests from QueueTest (27 ms total)

[----------] 7 tests from Surface2DTest
[ RUN      ] Surface2DTest.MultipleSizes
[       OK ] Surface2DTest.MultipleSizes (172 ms)
[ RUN      ] Surface2DTest.PlanarFormats
[       OK ] Surface2DTest.PlanarFormats (80 ms)
[ RUN      ] Surface2DTest.DestroyNull
[       OK ] Surface2DTest.DestroyNull (14 ms)
[ RUN      ] Surface2DTest.ReadWrite
[       OK ] Surface2DTest.ReadWrite (29 ms)
[ RUN      ] Surface2DTest.ReadWriteWithStride
[       OK ] Surface2DTest.ReadWriteWithStride (14 ms)
[ RUN      ] Surface2DTest.Initialization
[       OK ] Surface2DTest.Initialization (13 ms)
[ RUN      ] Surface2DTest.GetInfo
[       OK ] Surface2DTest.GetInfo (27 ms)
[----------] 7 tests from Surface2DTest (349 ms total)

[----------] 3 tests from Surface2DUPTest
[ RUN      ] Surface2DUPTest.MultipleSizes
[       OK ] Surface2DUPTest.MultipleSizes (138 ms)
[ RUN      ] Surface2DUPTest.InvalidSystemMemory
[       OK ] Surface2DUPTest.InvalidSystemMemory (27 ms)
[ RUN      ] Surface2DUPTest.PlanarFormat
[       OK ] Surface2DUPTest.PlanarFormat (53 ms)
[----------] 3 tests from Surface2DUPTest (218 ms total)

[----------] 4 tests from Surface3DTest
[ RUN      ] Surface3DTest.MultipleSizes
[       OK ] Surface3DTest.MultipleSizes (135 ms)
[ RUN      ] Surface3DTest.Abgr16Format
[       OK ] Surface3DTest.Abgr16Format (27 ms)
[ RUN      ] Surface3DTest.ReadWrite
[       OK ] Surface3DTest.ReadWrite (13 ms)
[ RUN      ] Surface3DTest.Initialization
[       OK ] Surface3DTest.Initialization (14 ms)
[----------] 4 tests from Surface3DTest (189 ms total)

[----------] 1 test from TaskTest
[ RUN      ] TaskTest.CreateDestroy
[       OK ] TaskTest.CreateDestroy (14 ms)
[----------] 1 test from TaskTest (14 ms total)

[----------] 3 tests from ThreadSpaceTest
[ RUN      ] ThreadSpaceTest.MultipleSizes
[       OK ] ThreadSpaceTest.MultipleSizes (27 ms)
[ RUN      ] ThreadSpaceTest.DependencyPattern
[       OK ] ThreadSpaceTest.DependencyPattern (27 ms)
[ RUN      ] ThreadSpaceTest.MediaWalkingPattern
[       OK ] ThreadSpaceTest.MediaWalkingPattern (29 ms)
[----------] 3 tests from ThreadSpaceTest (84 ms total)

[----------] Global test environment tear-down
[==========] 43 tests from 13 test cases ran. (1505 ms total)
[  PASSED  ] 43 tests.

Note, to avoid regressing build in future consider FreeBSD-friendly CI.

[jbeich]

@iamleot, @iarebatman, can you test on NetBSD and OpenBSD? intel-vaapi-driver is deprecated in favor of media-driver. This PR fixes both DragonFly and FreeBSD but if it also fixes NetBSD and OpenBSD it'd increase upstream buy in. ;)

[iamleot]

Hello Jan,
Sure! I'll hopefully be able to test it on NetBSD/amd64 later this UTC evening. Unfortunately I only have 4th generation Intel CPUs so I think that I can only build test them.

Both intel/gmmlib#68 and #819 NetBSD parts looks good to me after quick skimming them.

[iamleot]

Hello Jan, Jan Beich writes:

@iamleot, did you forget to test media-driver after gmmlib built fine? gmmlib is ~15x smaller than media-driver, so I expect more fun here. (Just a reminder. I'll remove this comment shortly after.)

No, I haven't and now that gmmlib seems ready I can finally test it. I hope to test and share news this evening! Thanks for the remainder and for working on that!

[jbeich]

@iamleot wrote:

I hope to test and share news this evening!

Do you still plan to? See also intel/libva#363

[iamleot]

Hello Jan, Jan Beich writes:

@iamleot wrote: > I hope to test and share news this evening! Do you still plan to? See also intel/libva#363

Sorry for the delay and (upstream) please consider my test not blocking (I was pretty busy in the last weeks). I'll hopefully have more time this weekend but I couldn't promise anything.

[jbeich]

Porting 6cafa0b is harder than expected due to bundled libdrm. Intel didn't bother documenting exact revision the code was taken from and BSDs didn't bother upstreaming all of their patches. I've dropped my incomplete attempt to add missing pieces, leaving cmrtlib partially broken on BSDs. The regressing commit can be reverted downstream until a proper fix is found.

Note, cmrtlib can be disabled via -DBUILD_CMRTLIB=OFF and seems to be used only by MediaSDK.

[jbeich]

cache (including ccache) doesn't work due to TravisCI bug. If ~12 minutes is too long I can add a CirrusCI config.

$ export CASHER_DIR=${TRAVIS_HOME}/.casher
$ Installing caching utilities
/home/travis/.rvm/scripts/set: /home/travis/.casher/bin/casher: /bin/bash: bad interpreter: No such file or directory
/home/travis/.rvm/scripts/set: line 19: /home/travis/.casher/bin/casher: No error: 0

[jbeich]

casher was fixed, so cache nowadays works but ccache in this repo doesn't for some reason:

preprocessor error 752

[dvrogozh]

As much as I wish to take this PR in, there is an issue that we have unpatched dependency (gmmlib). This means that the best we can do (w/o having permanently patched gmmlib) would be to setup ci based on PR against gmmlib - that's what is actually done in this PR. This has a problem however that we risk to have ci failures on gmmlib updates. Someone will need to fix PR against gmmlib. And ci fill be down during the time gmmlib PR is getting fixed. To be honest, this is not something I wish to setup and track.

I would suggest however to start picking up patches in this PR one by one reducing number of patches we have here. Some of them look to be ready to go, some might need further discussion.