replace the reconstruct surface to be variant #915
Conversation
XinfengZhang
force-pushed
the
recon_format
branch
from
5169e35
to
fbfb950
Compare
There was a problem hiding this comment.
Hi @XinfengZhang, thanks for working this out.
Verified with AYUV and Y410 encoding, this recon methods for me without resize on application level.
However, previous concern about Y210 still existed, and we'd better handle Y210 as well.
(Verified, garbage still existed.)
XinfengZhang
force-pushed
the
recon_format
branch
from
859cddf
to
c3dafe7
Compare
|
updated for Y210 |
| DdiMediaUtil_LockMutex(&mediaCtx->SurfaceMutex); | ||
| uint32_t i; | ||
| //get current element heap and index | ||
| for(i = 0; i < mediaCtx->pSurfaceHeap->uiAllocatedHeapElements; i ++) |
There was a problem hiding this comment.
Maybe we can replace this segment with DdiMedia_GetVASurfaceIDFromSurface.
| surfaceElement ++; | ||
| } | ||
| //if cant find | ||
| if(i == surface->pMediaCtx->pSurfaceHeap->uiAllocatedHeapElements) |
There was a problem hiding this comment.
I think it will be great if we move this condition checking to the beginning of the function, then we will no need to allocate the dstSurface.
| @@ -298,6 +298,8 @@ typedef struct _DDI_MEDIA_SURFACE | |||
| uint8_t *pSystemShadow; // Shadow surface in system memory | |||
|
|
|||
| uint32_t uiMapFlag; | |||
|
|
|||
| uint32_t uiVariantFlag; | |||
There was a problem hiding this comment.
Are there any reserved purposes for this flag? If no, maybe bool is enough for it.
|
@XinfengZhang Note that MSDK needs some related change for this, otherwise it'll break the current encoding path since the surface reallocation is handled inside driver now. |
XinfengZhang
force-pushed
the
recon_format
branch
from
c3dafe7
to
1df8427
Compare
|
Verified with this patch applied on 7620ba2, works for me for both Y210 and AYUV/Y410. |
| DDI_CHK_RET(RegisterRTSurfaces(&(m_encodeCtx->RTtbl), DdiMedia_GetSurfaceFromVASurfaceID(mediaCtx, picParams->decoded_curr_pic.picture_id)), "RegisterRTSurfaces failed!"); | ||
| surface = DdiMedia_GetSurfaceFromVASurfaceID(mediaCtx, picParams->decoded_curr_pic.picture_id); | ||
|
|
||
| if(m_encodeCtx->vaProfile == VAProfileHEVCMain444 |
XinfengZhang
force-pushed
the
recon_format
branch
2 times, most recently
from
44a9782
to
2608509
Compare
replace the reconstruct surface to be variant surface for HEVC REXT encoding it could make the difference between recon/raw to be transparent to application pay attention , the surface should be not read or write. Signed-off-by: XinfengZhang <carl.zhang@intel.com>
Signed-off-by: XinfengZhang <carl.zhang@intel.com>
XinfengZhang
added
Encode
|
corresponding msdk change Intel-Media-SDK/MediaSDK#2151 |
replace the reconstruct surface to be variant surface for HEVC REXT encoding
it could make the difference between recon/raw to be transparent to application
pay attention , the surface should be not read or write.
Signed-off-by: XinfengZhang carl.zhang@intel.com