Add clusterNetwork/defaultNetwork into multus.conf #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
requested review from
rkamudhan and
dougbtv
and removed request for
rkamudhan
s1061123
commented
Oct 16, 2018
s1061123
changed the title
s1061123
force-pushed
the
dev/defaultnet
branch
from
4494dc2
to
b01896d
Compare
Pull Request Test Coverage Report for Build 446
💛 - Coveralls |
To support CRD/file/directory, add clusterNetwork/defaultNetwork in multus.conf file.
To support CRD/file/directory, add clusterNetwork/defaultNetwork in multus.conf file.
To support CRD/file/directory, add clusterNetwork/defaultNetwork in multus.conf file.
s1061123
force-pushed
the
dev/defaultnet
branch
from
dfe35bb
to
2f213ee
Compare
s1061123
commented
Oct 18, 2018
| if n.ClusterNetwork != "" { | ||
| err = k8s.GetDefaultNetworks(k8sArgs, n, kubeClient) | ||
| if err != nil { | ||
| return nil, logging.Errorf("XXX") |
There was a problem hiding this comment.
need to replace 'XXX' with more good error message.
dougbtv
approved these changes
Oct 25, 2018
This was referenced May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support CRD/file/directory, add clusterNetwork/defaultNetwork in multus.conf file.
Verified that kubernetes: v1.12.1.
Fix #157, #153, #131