Unit tests and update to quickstart guide #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
requested changes
Aug 2, 2019
k8sclient/k8sclient_test.go
Outdated
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| /* Still figuring this one out. need to make "setPodNetworkAnnotation throw an error */ |
There was a problem hiding this comment.
Golang prefers to use '//' than '/* */' for comments. Could you please change it?
k8sclient/k8sclient_test.go
Outdated
| } | ||
| }` | ||
|
|
||
| delegate, err := types.LoadDelegateNetConf([]byte(conf), nil, "0000:00:00.0") |
There was a problem hiding this comment.
In case of non-sriov case, 3rd argument of LoadDelegateNetConf() could be "" (empty) instead of "0000:00:00.0".
There was a problem hiding this comment.
I changed this in my most recent commit, but I'm not sure what "non-sriov case" means. Can you explain so I will know where/why such changes should be made for future? Thank you
kubeletclient/kubeletclient_test.go
Outdated
| @@ -115,6 +115,15 @@ var _ = Describe("Kubelet resource endpoint data read operations", func() { | |||
| _, err := GetResourceClient() | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| }) | |||
|
|
|||
| It("should fail with missing file", func() { | |||
| // os.Mkdir("tempdir", 0644) | |||
There was a problem hiding this comment.
Could you remove commented out code (if it is not necessary)?
kubeletclient/kubeletclient_test.go
Outdated
|
|
||
| It("should fail with missing file", func() { | ||
| // os.Mkdir("tempdir", 0644) | ||
| kubeletSocket = "Andrew Bays" |
There was a problem hiding this comment.
Good example to us but not so universal 😆 We may use simple string for that, like "sampleSocketString".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional unit tests and added a stub section for Network Status Annotations in quickstart.md