Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests and update to quickstart guide #354

Merged
merged 26 commits into from Aug 5, 2019

Conversation

@nicklesimba
Copy link
Contributor

commented Aug 1, 2019

Added additional unit tests and added a stub section for Network Status Annotations in quickstart.md

nicklesimba added some commits Jun 10, 2019

@coveralls

This comment has been minimized.

Copy link

commented Aug 1, 2019

Pull Request Test Coverage Report for Build 835

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.7%) to 71.089%

Totals Coverage Status
Change from base Build 833: 7.7%
Covered Lines: 927
Relevant Lines: 1304

💛 - Coveralls
@s1061123
Copy link
Collaborator

left a comment

Thank you for this PR! It must increase the code coverage, awesome!

I add some minor comment, so could you please take a look into it?
Once changed, let's merge it.

Expect(err).NotTo(HaveOccurred())
})

/* Still figuring this one out. need to make "setPodNetworkAnnotation throw an error */

This comment has been minimized.

Copy link
@s1061123

s1061123 Aug 2, 2019

Collaborator

Golang prefers to use '//' than '/* */' for comments. Could you please change it?

}
}`

delegate, err := types.LoadDelegateNetConf([]byte(conf), nil, "0000:00:00.0")

This comment has been minimized.

Copy link
@s1061123

s1061123 Aug 2, 2019

Collaborator

In case of non-sriov case, 3rd argument of LoadDelegateNetConf() could be "" (empty) instead of "0000:00:00.0".

This comment has been minimized.

Copy link
@nicklesimba

nicklesimba Aug 5, 2019

Author Contributor

I changed this in my most recent commit, but I'm not sure what "non-sriov case" means. Can you explain so I will know where/why such changes should be made for future? Thank you

@@ -115,6 +115,15 @@ var _ = Describe("Kubelet resource endpoint data read operations", func() {
_, err := GetResourceClient()
Expect(err).NotTo(HaveOccurred())
})

It("should fail with missing file", func() {
// os.Mkdir("tempdir", 0644)

This comment has been minimized.

Copy link
@s1061123

s1061123 Aug 2, 2019

Collaborator

Could you remove commented out code (if it is not necessary)?


It("should fail with missing file", func() {
// os.Mkdir("tempdir", 0644)
kubeletSocket = "Andrew Bays"

This comment has been minimized.

Copy link
@s1061123

s1061123 Aug 2, 2019

Collaborator

Good example to us but not so universal 😆 We may use simple string for that, like "sampleSocketString".

@dougbtv dougbtv merged commit 9085c84 into intel:master Aug 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+7.7%) to 71.089%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.