Support Infiniband guid CNI runtime config #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `infinibandGUID` CNI runtime config - Add `infiniband-guid` Network attachment attribute - Reflect infiniband guid request in Delegate network config
This commit extend the various network conf methods to translate `infiniband-guid` network attachment configuration to `infinibandGUID` CNI runtime config. - Update relevant methods in types package - Update unit tests
|
Adrian, thanks a bunch for the PR! Let's make sure the proposal is accepted before we merge it. |
|
Hi @dougbtv appreciate a pair of eyes on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for a new CNI runtime config attribute
InfinibandGUIDCNI runtime config which was introduced in PR 742the corresponding network-attachment attribute is proposed to be defined as
infiniband-guidand discussed in multi-net-spec PR 4
A CNI implementation consuming this runtime config attribute (and can be used as reference) is proposed in ib-sriov-cni PR 28