support bias shift in outlier suppression+ #1231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR target for v2.4? |
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
n1ck-guo
approved these changes
Dec 21, 2023
wenhuach21
reviewed
Dec 21, 2023
wenhuach21
reviewed
Dec 21, 2023
neural_compressor/adaptor/onnxrt.py
Outdated
| @@ -181,6 +181,7 @@ def smooth_quant( | |||
| "alpha_step": 0.1, | |||
| "shared_criterion": "mean", | |||
| "do_blockwise": False, | |||
| "shift_bias": False, | |||
There was a problem hiding this comment.
how about using **kwargs, otherwise, each time we need to add the keywords for different backends
There was a problem hiding this comment.
auto_alpha_args is already added to kwargs in /algorithm/smooth_quant.py.
Just adding the arguments and related docstrings for onnx and tensorflow.
wenhuach21
reviewed
Dec 21, 2023
for more information, see https://pre-commit.ci
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
wenhuach21
changed the title
Signed-off-by: Lu, Yintong <yintong.lu@intel.com>
|
As discussed, bias shift will be a separate module, so this pr will not be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
feature
Description
enable bias-shifting of outlier suppression + in SQ
Note: this is still under development and debugging
Expected Behavior & Potential Risk
How has this PR been tested?
Dependency Change?
no library dependency introduced or removed