Remove deprecated modules #1872

chensuyue · 2024-06-14T15:18:44Z

Type of Change

others

Description

Remove deprecated modules, neural_solution, neural_insights, neural_coder

Expected Behavior & Potential Risk

CI pass

How has this PR been tested?

CI

Dependency Change?

Yes, remove some deps.

Signed-off-by: chensuyue <suyue.chen@intel.com>

github-actions · 2024-06-14T15:19:17Z

⛈️ Required checks status: Has failure 🔴

Warning
If you do not have the access to re-run the Probot, please contact XuehaoSun for help. If you push a new commit, all of the workflow will be re-triggered.

Groups summary

🟢 Code Scan Tests workflow

Check ID	Status
Code-Scan	success	✅
Code-Scan (Bandit Code Scan Bandit)	success	✅
Code-Scan (DocStyle Code Scan DocStyle)	success	✅
Code-Scan (Pylint Code Scan Pylint)	success	✅

These checks are required after the changes to neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/util.py, neural_compressor/benchmark.py, neural_compressor/config.py, neural_compressor/quantization.py, neural_compressor/strategy/strategy.py, neural_compressor/template/qat.yaml, neural_compressor/utils/neural_insights_utils.py, setup.py, .azure-pipelines/scripts/codeScan/pydocstyle/pydocstyle.sh, .azure-pipelines/scripts/codeScan/pydocstyle/scan_path_neural_insights.txt, .azure-pipelines/scripts/codeScan/pydocstyle/scan_path_neural_solution.txt, .azure-pipelines/scripts/codeScan/pylint/pylint.sh.

🟢 Model Tests workflow

Check ID	Status
Model-Test	success	✅
Model-Test (Generate Report GenerateReport)	success	✅
Model-Test (Run ONNX Model resnet50-v1-12)	success	✅
Model-Test (Run PyTorch Model resnet18_fx)	success	✅
Model-Test (Run TensorFlow Model resnet50v1.5)	success	✅
Model-Test (Run TensorFlow Model ssd_resnet50_v1)	success	✅

These checks are required after the changes to neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/util.py, neural_compressor/benchmark.py, neural_compressor/config.py, neural_compressor/quantization.py, neural_compressor/strategy/strategy.py, neural_compressor/template/qat.yaml, neural_compressor/utils/neural_insights_utils.py, setup.py.

🟢 Model Tests 3x workflow

Check ID	Status
Model-Test-3x	success	✅
Model-Test-3x (Generate Report GenerateReport)	success	✅
Model-Test-3x (Run PyTorch Model opt_125m_woq_gptq_int4)	success	✅
Model-Test-3x (Run PyTorch Model opt_125m_woq_gptq_int4_dq_bnb)	success	✅
Model-Test-3x (Run PyTorch Model opt_125m_woq_gptq_int4_dq_ggml)	success	✅

These checks are required after the changes to setup.py.

🔴 Unit Tests basic workflow

Check ID	Status	Error details
UT-Basic	failure		❌
UT-Basic (Coverage Compare CollectDatafiles)	failure	download	❌
UT-Basic (Unit Test FWKs adaptor Test FWKs adaptor)	success		✅
UT-Basic (Unit Test FWKs adaptor baseline Test FWKs adaptor baseline)	success		✅
UT-Basic (Unit Test ITEX Test ITEX)	success		✅
UT-Basic (Unit Test ITEX baseline Test ITEX baseline)	success		✅
UT-Basic (Unit Test Pruning Test PyTorch Pruning)	success		✅
UT-Basic (Unit Test Pruning Test TensorFlow Pruning)	success		✅
UT-Basic (Unit Test Pruning baseline Test PyTorch Pruning baseline)	success		✅
UT-Basic (Unit Test Pruning baseline Test TensorFlow Pruning baseline)	success		✅
UT-Basic (Unit Test TF newAPI Test TF newAPI)	success		✅
UT-Basic (Unit Test TF newAPI baseline Test TF newAPI baseline)	success		✅
UT-Basic (Unit Test User facing API Test User facing API)	success		✅
UT-Basic (Unit Test User facing API baseline Test User facing API baseline)	success		✅
UT-Basic (Unit Test other basic case Test other basic case)	success		✅
UT-Basic (Unit Test other cases baseline Test other cases baseline)	success		✅

UT-Basic coverage report

	Base coverage	PR coverage	Diff
Lines	76.018%	75.668%	-0.350%
Branches	65.105%	64.724%	-0.381%

Commit	FileName	Stmts	Miss	Branch	Cover
PR \| BASE	adaptor/onnxrt.py	1132 \| 1154	176 \| 197	626 \| 642	82% \| 81%
PR \| BASE	adaptor/pytorch.py	2154 \| 2168	641 \| 654	1041 \| 1049	67% \| 66%
PR \| BASE	adaptor/tensorflow.py	1216 \| 1219	401 \| 351	593 \| 593	64% \| 69%
PR \| BASE	adaptor/tf_utils/graph_util.py	491 \| 491	53 \| 55	274 \| 274	87% \| 87%
PR \| BASE	adaptor/tf_utils/util.py	416 \| 442	61 \| 42	227 \| 237	79% \| 84%
PR \| BASE	compression/hpo/search_algorithms.py	154 \| 154	4 \| 5	56 \| 56	97% \| 96%
PR \| BASE	config.py	935 \| 971	60 \| 61	239 \| 253	87% \| 87%
PR \| BASE	quantization.py	63 \| 72	4 \| 7	20 \| 26	95% \| 91%
PR \| BASE	strategy/strategy.py	1019 \| 1067	195 \| 198	405 \| 419	78% \| 79%
PR \| BASE	utils/neural_insights_utils.py	NA \| 78	NA \| 67	NA \| 12	NA \| 12%
PR \| BASE	utils/utility.py	565 \| 565	240 \| 121	210 \| 210	52% \| 74%
PR \| BASE	utils/weights_details.py	21 \| 21	11 \| 2	0 \| 0	48% \| 90%

These checks are required after the changes to neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/util.py, neural_compressor/benchmark.py, neural_compressor/config.py, neural_compressor/quantization.py, neural_compressor/strategy/strategy.py, neural_compressor/template/qat.yaml, neural_compressor/utils/neural_insights_utils.py, test/neural_coder/test_common.py, test/neural_coder/test_line_operation.py, test/strategy/test_basic.py, setup.py, .azure-pipelines/scripts/ut/run_basic_others.sh, .azure-pipelines/scripts/ut/run_ncoder.sh, .azure-pipelines/scripts/ut/run_neural_insights.sh, .azure-pipelines/scripts/ut/run_neural_solution.sh.

🟢 Unit Tests basic no coverage workflow

Check ID	Status
UT-Basic-No-Coverage	success	✅
UT-Basic-No-Coverage (Unit Test FWKs adaptor Test FWKs adaptor)	success	✅
UT-Basic-No-Coverage (Unit Test Pruning Test PyTorch Pruning)	success	✅
UT-Basic-No-Coverage (Unit Test Pruning Test TensorFlow Pruning)	success	✅
UT-Basic-No-Coverage (Unit Test User facing API Test User facing API)	success	✅
UT-Basic-No-Coverage (Unit Test other basic case Test other basic case)	success	✅

These checks are required after the changes to neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/util.py, neural_compressor/benchmark.py, neural_compressor/config.py, neural_compressor/quantization.py, neural_compressor/strategy/strategy.py, neural_compressor/template/qat.yaml, neural_compressor/utils/neural_insights_utils.py, test/neural_coder/test_common.py, test/neural_coder/test_line_operation.py, test/strategy/test_basic.py, setup.py, .azure-pipelines/scripts/ut/run_basic_others.sh, .azure-pipelines/scripts/ut/run_ncoder.sh, .azure-pipelines/scripts/ut/run_neural_insights.sh, .azure-pipelines/scripts/ut/run_neural_solution.sh.

🔴 Unit Tests ITREX workflow

Check ID	Status	Error details
UT-ITREX	failure	download	❌

These checks are required after the changes to neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/util.py, neural_compressor/benchmark.py, neural_compressor/config.py, neural_compressor/quantization.py, neural_compressor/strategy/strategy.py, neural_compressor/template/qat.yaml, neural_compressor/utils/neural_insights_utils.py, setup.py.

🟢 Unit Tests 3x-TensorFlow workflow

Check ID	Status
UT-3x-TensorFlow	success	✅
UT-3x-TensorFlow (Coverage Compare CollectDatafiles)	success	✅
UT-3x-TensorFlow (Unit Test 3x TensorFlow Unit Test 3x TensorFlow)	success	✅
UT-3x-TensorFlow (Unit Test 3x TensorFlow baseline Unit Test 3x TensorFlow baseline)	success	✅

These checks are required after the changes to setup.py.

🟢 Unit Tests 3x-PyTorch workflow

Check ID	Status
UT-3x-Torch	success	✅
UT-3x-Torch (Coverage Compare CollectDatafiles)	success	✅
UT-3x-Torch (Unit Test 3x Torch Unit Test 3x Torch)	success	✅
UT-3x-Torch (Unit Test 3x Torch baseline Unit Test 3x Torch baseline)	success	✅

These checks are required after the changes to setup.py.

🟢 Unit Tests 3x-ONNXRT workflow

Check ID	Status
UT-3x-ONNXRT	success	✅
UT-3x-ONNXRT (Coverage Compare CollectDatafiles)	success	✅
UT-3x-ONNXRT (Unit Test 3x ONNXRT Unit Test 3x ONNXRT)	success	✅
UT-3x-ONNXRT (Unit Test 3x ONNXRT baseline Unit Test 3x ONNXRT baseline)	success	✅

These checks are required after the changes to setup.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and will be updates every 180 seconds within the next 6 hours. If you have any other questions, contact chensuyue or XuehaoSun for help.

…nto suyue/bump_version # Conflicts: # .github/checkgroup.yml # neural_coder/coders/tensorflow/amp.py # neural_coder/coders/tensorflow/inc.py # neural_insights/components/model/onnxrt/model.py # neural_insights/components/model/tensorflow/model.py # neural_solution/frontend/utility.py

Signed-off-by: chensuyue <suyue.chen@intel.com>

for more information, see https://pre-commit.ci

yiliu30

Please remove Neural Coder related doc at README.md

README.md

Signed-off-by: chensuyue <suyue.chen@intel.com>

chensuyue · 2024-07-12T03:12:13Z

UT-ITREX failed due to the ITREX PR intel/intel-extension-for-transformers#1606, will fixed in another PR.

chensuyue added 2 commits June 14, 2024 23:15

remove neural coder, neural insights, neural solution from master branch

77b280f

Signed-off-by: chensuyue <suyue.chen@intel.com>

bump version into v3.0

98f5785

Signed-off-by: chensuyue <suyue.chen@intel.com>

chensuyue added this to the v3.0 milestone Jun 14, 2024

chensuyue added 3 commits July 11, 2024 17:27

remove the integration of neural_insights

2e1823c

Signed-off-by: chensuyue <suyue.chen@intel.com>

remove the integration of neural_solution

6d9db44

Signed-off-by: chensuyue <suyue.chen@intel.com>

chensuyue requested review from yiliu30, thuang6 and XuehaoSun July 11, 2024 09:47

pre-commit-ci bot and others added 2 commits July 11, 2024 09:48

[pre-commit.ci] auto fixes from pre-commit.com hooks

0c1c2cc

for more information, see https://pre-commit.ci

Merge branch 'master' into suyue/bump_version

e748023

yiliu30 approved these changes Jul 11, 2024

View reviewed changes

README.md Show resolved Hide resolved

remove the integration of neural_coder

5416c92

Signed-off-by: chensuyue <suyue.chen@intel.com>

XuehaoSun approved these changes Jul 12, 2024

View reviewed changes

chensuyue merged commit 1703658 into master Jul 12, 2024
54 of 57 checks passed

chensuyue deleted the suyue/bump_version branch July 12, 2024 03:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated modules #1872

Remove deprecated modules #1872

chensuyue commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024 •

edited

Loading

yiliu30 left a comment

chensuyue commented Jul 12, 2024

Remove deprecated modules #1872

Remove deprecated modules #1872

Conversation

chensuyue commented Jun 14, 2024 • edited Loading

Type of Change

Description

Expected Behavior & Potential Risk

How has this PR been tested?

Dependency Change?

github-actions bot commented Jun 14, 2024 • edited Loading

⛈️ Required checks status: Has failure 🔴

Groups summary

yiliu30 left a comment

Choose a reason for hiding this comment

chensuyue commented Jul 12, 2024

chensuyue commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024 •

edited

Loading