Neural Coder enable VS Code extension #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
kaikaiyao
changed the title
|
LGTM. When CI is passed, we can merge this. |
kaikaiyao
approved these changes
Dec 2, 2022
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
|
You have added a list of 3rd party deps into BoM list, so pls fix this answer 'Dependency Change?'. |
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
|
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
chensuyue
reviewed
Dec 2, 2022
chensuyue
approved these changes
Dec 3, 2022
|
@WenjiaoYue Could you take a look at the conflicts? I don't know what this is |
kaikaiyao
changed the title
|
Please rebase master to resolve this conflict. |
Signed-off-by: mengfeil <kai.yao@intel.com>
Signed-off-by: mengfeil <kai.yao@intel.com>
Signed-off-by: mengfeil <kai.yao@intel.com>
zehao-intel
pushed a commit
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com> Signed-off-by: mengfeil <kai.yao@intel.com> Signed-off-by: zehao-intel <zehao.huang@intel.com>
VincyZhang
added a commit
that referenced
this pull request
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yue, Wenjiao wenjiao.yue@intel.com
Type of Change
add vscode_extension feature
Description
add vscode_extension feature
Expected Behavior & Potential Risk
can use in vscode
How has this PR been tested?
search vscode in vscode market
Dependency Change?
yes
Details are as follows：
@types/fs-extra，@types/mocha，@types/glob， @types/vscode，@typescript-eslint/eslint-plugin，@typescript-eslint/parser，@vscode/test-electroneslint，ts-loader，webpack，webpack-cli，python-shell