Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D U-Net TensorFlow workspace for BraTS 2020 #108

Merged
merged 67 commits into from Aug 5, 2021

Conversation

tonyreina
Copy link
Contributor

This adds a workspace for OpenFL to train a TensorFlow 3D U-Net model on BraTS 2020.

  • I show how to use a TensorFlow dataloader rather than loading everything into memory. It should make for a nice example to showcase how to use custom data loaders

  • I fixed a bug in the KerasRunner on the validation function. It was using x_validate rather than the get_valid_data() function. This change makes it possible to use an arbitrary dataloader.

  • I think there's a bug with db_rounds to keep. When I set it to 1 round to keep, the federation crashes on round 2 because it doesn't have the graph variables. It looks like this should be at least >=2 rounds to keep. I'd suggest doing a max(db_rounds, 2) so that the user doesn't inadvertently put in something like 0 (or -999).

  • The model trains, but no guarantees on a good Dice score. It's just a template.

Hope you all are well. спасибо друзья!

@alexey-gruzdev
Copy link
Contributor

@tonyreina it seems that we still have few of them with fresh CI build.

@tonyreina
Copy link
Contributor Author

I think flake passes now.

@tonyreina tonyreina requested a review from itrushkin July 12, 2021 21:49
@itrushkin
Copy link
Contributor

Great work! Thanks!

@alexey-gruzdev alexey-gruzdev added this to the v1.2 milestone Jul 21, 2021
@itrushkin
Copy link
Contributor

Jenkins please retry a build

@alexey-gruzdev
Copy link
Contributor

@tonyreina thanks for the contribution! I've tested this, so it worked well.

@alexey-gruzdev alexey-gruzdev merged commit e5bf981 into securefederatedai:develop Aug 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants