Interactive API Experiment - Pytorch Re-ID on Market #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
ok to test |
alexey-gruzdev
requested review from
igor-davidyuk,
aleksandr-mokrov and
itrushkin
...l-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/two/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
itrushkin
suggested changes
Aug 18, 2021
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/director_folder/director_config.yaml
Outdated
Show resolved
Hide resolved
...l-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/one/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/one/start_envoy.sh
Outdated
Show resolved
Hide resolved
...l-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/two/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/two/start_envoy.sh
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/workspace/transforms.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/workspace/transforms.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/workspace/transforms.py
Outdated
Show resolved
Hide resolved
...l-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/one/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
itrushkin
approved these changes
Aug 19, 2021
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/Pytorch_Market_Re-ID/envoy_folder/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
| " else:\n", | ||
| " batch_size = 512\n", | ||
| " \n", | ||
| " self.shard_descriptor.set_mode('query')\n", |
There was a problem hiding this comment.
We probably should pass shard_descriptor to DataLoader by deep copying it.
When the Pytorch DataLoader will try to access shard_descriptor the mode may be already changed
There was a problem hiding this comment.
added shard descriptor's copies to gallery and query loaders
|
Could you also clear all cell outputs |
* Use epochs instead batch_num. Log epoch count * Fix flake8 * Resolve conversations * Fix linter Co-authored-by: Ilya Trushkin <ilya.trushkin@intel.com>
Co-authored-by: igor-davidyuk <76463150+igor-davidyuk@users.noreply.github.com>
|
@katerina-merkulova thanks for fixes, LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tutorial experiment to Interactive API - Pytorch Re-ID (Resnet50 and Arcface loss) on Market1501 dataset.