Use epochs instead batch_num. Log current epoch number #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itrushkin
reviewed
Aug 24, 2021
| @@ -60,7 +60,8 @@ def rebuild_model(self, round_num, input_tensor_dict, validation=False): | |||
| else: | |||
| self.set_tensor_dict(input_tensor_dict, with_opt_vars=False) | |||
|
|
|||
| def train(self, col_name, round_num, input_tensor_dict, metrics, num_batches=None, **kwargs): | |||
| def train(self, col_name, round_num, input_tensor_dict, | |||
| metrics, epochs=1, batch_size=1, **kwargs): | |||
| """ | |||
| Perform the training for a specified number of batches. | |||
There was a problem hiding this comment.
Docstring should be updated since num_batches is not specified anymore.
openfl/federated/task/runner_pt.py
Outdated
| @@ -129,7 +129,7 @@ def validate(self, col_name, round_num, input_tensor_dict, | |||
| return output_tensor_dict, {} | |||
|
|
|||
| def train_batches(self, col_name, round_num, input_tensor_dict, | |||
| num_batches=None, use_tqdm=False, **kwargs): | |||
| num_batches=None, use_tqdm=False, epochs=1, **kwargs): | |||
There was a problem hiding this comment.
Could num_batches be removed here as well?
openfl/federated/task/runner_tf.py
Outdated
| @@ -84,7 +84,7 @@ def rebuild_model(self, round_num, input_tensor_dict, validation=False): | |||
| self.set_tensor_dict(input_tensor_dict, with_opt_vars=False) | |||
|
|
|||
| def train_batches(self, col_name, round_num, input_tensor_dict, | |||
| num_batches, use_tqdm=False, **kwargs): | |||
| epochs=1, use_tqdm=False, **kwargs): | |||
| """ | |||
| Perform the training for a specified number of batches. | |||
There was a problem hiding this comment.
Docstring should be updated since num_batches is not specified anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some workspaces used num_batches value for global number of batches. Now all of them use epochs number