-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.1 + master patches: build fails #53
Comments
After remove hardcoded
|
And after disable LTO It is yet another batch of issies
|
After add |
Multiple modules use implicit conversion between enum types, but this triggers warnings with some compilers. ex: qbg/vdp_cmds.c:110:39: error: implicit conversion from enumeration type 'lldp_cmd' to different enumeration type 'cmd_status' [-Werror,-Wenum-conversion] cmd_status good_cmd = vdp_cmdok(cmd, cmd_gettlv); Reported-at: intel#53 Signed-off-by: Aaron Conole <aconole@redhat.com>
See the following branch (well pointed to the final commit): This should resolve build errors under gcc-10 - let me know. I'm going to send a pull request with all of the commits once build is complete. |
Yep it works now :) Thank you. BTW I think that it is already enough patches commited to make new release. |
We are having a discussion about that today and another meeting tomorrow.
I'll send an update either tomorrow or Wednesday.
Pleasantly,
Ronald Bynoe
…On Mon, Aug 3, 2020, 15:25 Tomasz Kłoczko ***@***.***> wrote:
Yep it works now :)
Thank you.
BTW I think that it is already enough patches commited to make new release.
Just humble question: do you have any plans to make new release soon? 😋
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR3NBGN6QZZD4QC24HOVTR642NTANCNFSM4OQJYHAA>
.
|
Thank you. |
Update .. I was wroong about link time issues.
|
Sorry .. I'm a bit messy today. |
Tomasz Kłoczko <notifications@github.com> writes:
Sorry .. I'm a bit messy today.
This is not LTO but -fno-common issue. In other words still it is necessary to pass -fcommon in $CFLAGS to compile openlldp.
Yuck - I'm going to add another commit to the pull request that should
fix this.
|
I tested the following: by running: make CFLAGS='-fno-common -O2 -g' LDFLAGS='-flto=auto' Successfully compiled on my system. Please let me know if it fixes on your system. |
Just in case I'm usig gcc 10.2.1 from Fedora rawhide. |
Should be fixed, since #55 is merged. Closing. |
The text was updated successfully, but these errors were encountered: