Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

Resolve Coverity Scan findings #201

Closed
kalyankondapally opened this issue Feb 19, 2014 · 4 comments
Closed

Resolve Coverity Scan findings #201

kalyankondapally opened this issue Feb 19, 2014 · 4 comments
Assignees
Milestone

Comments

@kalyankondapally
Copy link
Contributor

I submitted our Milestone branch to CoverityScan [a] and had three findings from the tool:

event_converter_in_process.cc:

  1. Uninitialized variable output_observer_.

2)window_tree_host_delegate_wayland.cc (line 88)
. return_iterator: "this->open_windows()->begin()" returns an iterator for "this->open_windows()".

CID 1177784 (#1 of 1): Iterator container mismatch (MISMATCHED_ITERATOR)5. mismatched_iterator: Using iterator "this->open_windows()->begin()" from "this->open_windows()" with "windows".
3)keyboard_code_conversion.cc

CID 1177245 (#3 of 3): Inferred misuse of enum (MIXED_ENUMS)mixed_enums: Mixing enum types ui::KeyboardCode and ozonewayland::OZONECHARCODE for "keysym".

This issue is about fixing this first 2.

a) https://scan.coverity.com/projects/1437

@kalyankondapally kalyankondapally added this to the Valentine milestone Feb 19, 2014
@kalyankondapally kalyankondapally self-assigned this Feb 19, 2014
@kalyankondapally
Copy link
Contributor Author

For first issue:
kalyankondapally@f30b07b

For second issue:
kalyankondapally@bd92b18

@tiagovignatti PTAL

@kalyankondapally
Copy link
Contributor Author

@tiagovignatti We can even have a coverity badge to our README file now if we want to, it would look like this here: https://github.com/kalyankondapally/ozone-wayland/tree/master-polltest (Check the end of ReadMe file)

@tiagovignatti
Copy link
Contributor

cool, the coverity badge looks cute :) both patches LGTM. Thanks.

@kalyankondapally
Copy link
Contributor Author

Merged 09764e6
6ecb6ae

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants