Move matplotlib code into to the backend #36
Conversation
Pennycook
requested review from
Pennycook and
laserkelvin
and removed request for
Pennycook
There was a problem hiding this comment.
Thank you for doing this. The refactor is a lot cleaner, and it was much easier to review this without the PGF plots changes mixed in.
Things mostly look good to me. I have a couple of small suggestions, and I'd like to hear what @laserkelvin thinks too.
There was a problem hiding this comment.
This looks good to me, but I'd like @laserkelvin to weigh in too before I merge anything.
@swright87: This is really pedantic, but I'd also prefer if your commit message didn't end with a period. Would you mind changing that?
Signed-off-by: Steven Wright <steven.wright@york.ac.uk>
Signed-off-by: Steven Wright <steven.wright@york.ac.uk>
Signed-off-by: Steven Wright <steven.wright@york.ac.uk>
swright87
force-pushed
the
move-matplotlib-to-backend
branch
from
b898cfb
to
94554e7
Compare
Done (and fixed the previous commit message with a period too...). |
|
Thank you, @swright87! |
Related issues
N/A
Proposed changes
This PR moves the matplotlib code out of the
cascadeandnavchartupper level files and into thematplotlibbackend.This makes it clearer to extend the library with additional backends.