Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception if # applications > # markers #45

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Pennycook
Copy link
Contributor

The number of applications could exceed the number of markers because:

  • We default to matplotlib's list of 16 "filled" markers; or
  • A user-provided marker list is too small.

In both cases, an ApplicationStyle can be used to increase the number of markers.

This change effects both Cascade and NavChart plots.

Related issues

Closes #42.

Proposed changes

  • Raise an exception if the number of applications is greater than the number of markers.

The number of applications could exceed the number of markers because:
- We default to matplotlib's list of 16 "filled" markers; or
- A user-provided marker list is too small.

In both cases, an ApplicationStyle can be used to increase the number of
markers.

This change effects both Cascade and NavChart plots.

Signed-off-by: John Pennycook <john.pennycook@intel.com>
@Pennycook Pennycook added the bug Something isn't working label Apr 26, 2024
@Pennycook Pennycook added this to the 1.0.0 milestone Apr 26, 2024
Copy link
Contributor

@laserkelvin laserkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this exception, but just wanted to bring up my obsolete usage the other time trying to pass marker styles directly instead of the ApplicationStyle API. I'll create an issue.

@Pennycook Pennycook merged commit 68ae4d1 into intel:main Apr 26, 2024
5 checks passed
@Pennycook Pennycook deleted the marker-limit branch April 26, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascade plot crashes with too many applications
2 participants