Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaveDumper dumps improper vcd format for multi-bit values #129

Closed
mkorbel1 opened this issue Jun 6, 2022 · 0 comments · Fixed by #130
Closed

WaveDumper dumps improper vcd format for multi-bit values #129

mkorbel1 opened this issue Jun 6, 2022 · 0 comments · Fixed by #130
Labels
bug Something isn't working

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Jun 6, 2022

Describe the bug

Multi-bit values in dumped VCD files from WaveDumper are printed incorrectly.

Instead of things like 0101 it prints 1'b01'b11'b01'b1, which is a result of a toString change to LogicValue.

To Reproduce

Dump any waveform of multi-bit signals and look at the dumped waveform in a waveform viewer.

Expected behavior

Properly dumped waves.

Actual behavior

Corrupted waves, shows "------" in GtkWave

Additional context
The existing tests for WaveDumper did not test multi-bit values, only single bit values, which is how this bug was missed when it was introduced in v0.3.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #129, waveform dump bug for multi-bit values mkorbel1/rohd
1 participant
@mkorbel1