Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case and CaseZ don't use the edge-sampled version of expression #348

Closed
mkorbel1 opened this issue Apr 21, 2023 · 0 comments · Fixed by #349
Closed

Case and CaseZ don't use the edge-sampled version of expression #348

mkorbel1 opened this issue Apr 21, 2023 · 0 comments · Fixed by #349
Assignees
@mkorbel1
Labels
bug Something isn't working

Comments

@mkorbel1
Copy link
Contributor

Describe the bug

If you use a Case or CaseZ in a Sequential, the value used for computation from expression is based on current value instead of the *edge sampled` value. This causes incorrect simulation behavior.

To Reproduce

Put Case in a Sequential where expression changes after the edge sampling, e.g. off another Sequential.

Expected behavior

expression uses the edge-sampled value

Actual behavior

No response

Additional: Dart SDK info

No response

Additional: pubspec.yaml

No response

Additional: Context

Need to write tests for If, Case, and CaseZ that cover this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkorbel1 mkorbel1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #348: make Case and CaseZ use edge-sampled signals for expression evaluation mkorbel1/rohd
1 participant
@mkorbel1