await registered actions in Simulator
#252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
End of simulation and injected actions are
awaited in theSimulatoralready, but when you register an action withSimulator.registerActionthe function is notawaited. This PR makes it more consistent byawaiting actions registered that way as well.The implementation revealed that additional error handling was needed in some scenarios for
Sequentials, as well.Related Issue(s)
N/A
Testing
Added new tests which cover this behavior and adjusted tests which needed it.
Backwards-compatibility
It is somewhat of a different behavior than was previously there, but the inconsistency makes this change closer to a bug fix than a new feature or API change. It may break code that relied on
Simulator.registerActionnotawaiting in theSimulator.Documentation
Updated documentation for
registerAction