Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

Many SDK parameters are missing or not exposed in ROS2 #104

Open
ruffsl opened this issue Jan 13, 2020 · 1 comment
Open

Many SDK parameters are missing or not exposed in ROS2 #104

ruffsl opened this issue Jan 13, 2020 · 1 comment

Comments

@ruffsl
Copy link

ruffsl commented Jan 13, 2020

As compared to the ROS1 wrapper for the realsense, many of the original parameters for the SDK remain missing or not exposed as dynamic or runtime parameters in ROS2. For example, the boolean options for enabling/disabling the IR projector are not made available, making it inconvenient to use the stereo IR stream for visual inertial SLAM.

https://github.com/IntelRealSense/realsense-ros/blob/88f73074ba00c7826c9e48249b33237b54d78ea5/realsense2_camera/launch/rs_rgbd.launch#L96

align_depth: false
enable_pointcloud: true
dense_pointcloud: true

@ruffsl
Copy link
Author

ruffsl commented Jan 13, 2020

This would be something I'd be willing to help port over; suggestions from any maintainers is welcome.

It looks like the ROS1 wrapper has a ferry involved method for procedurally registering all ofthe realsense SKD options as node parameters, so I'd like to ask if we'd perser to replicate this behavior in the ROS2 wrapper, or go with a different approach. E.g.

https://github.com/IntelRealSense/realsense-ros/blob/ec68bddb042abeba820421835c8b3e968c1016c7/realsense2_camera/src/base_realsense_node.cpp#L384-L388

if (param_name == "accel0.enabled") {
result = toggleStream(ACCEL, param);
} else if (param_name == "gyro0.enabled") {
result = toggleStream(GYRO, param);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant