Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistic newton cg #84

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Logistic newton cg #84

merged 3 commits into from
Apr 9, 2019

Conversation

oleksandr-pavlyk
Copy link
Contributor

Supporting use of DAAL to compute loss function and its gradients for LogisticRegression(solver='newton-cg'). Due to lack of the corresponding functionality, computation of Hessian times a vector is still done in Python.

Use DAAL for computation of objective function with solver newton-cg
Application of Hessian applied to a vector without computing
the Hessian in full is done in Python for now.

comment out  _map_to_binary_logistic_regression() to mend Py2 builds (nonlocal is Py3 only).
Will be reinstanted once Python 2 is decomissioned
Copy link
Contributor

@Alexander-Makaryev Alexander-Makaryev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oleksandr-pavlyk oleksandr-pavlyk merged commit cd06279 into master Apr 9, 2019
@oleksandr-pavlyk oleksandr-pavlyk deleted the logistic-newton-cg branch April 9, 2019 19:03
Vika-F pushed a commit to Vika-F/scikit-learn-intelex that referenced this pull request Apr 4, 2024
* initial

* codefactor & EOF

* Update report_generator.py

* apply comments

* round ratio cell

* apply readme comments

* Update report_generator/README.md

* elastic-net->elasticnet && add iter in lasso & elasticnet && pca n_components int->float

* remove knn_regr

* Update sklearn_bench/pca.py

Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants