Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from synce4l-0.9.0 tarball fails #14

Closed
mlichvar opened this issue Jun 19, 2023 · 4 comments
Closed

Building from synce4l-0.9.0 tarball fails #14

mlichvar opened this issue Jun 19, 2023 · 4 comments

Comments

@mlichvar
Copy link
Contributor

The Makefile uses a git command to get a version string to be printed by the -v option. This command fails when building from the released tarball if not unpacked in a subdirectory of a git repository (in which case the version string is wrong).

Maybe the command could be expanded to check for the .git directory and fall back to a hardcoded version string, which could be update before each release?

@mmichaliINTC
Copy link
Contributor

Yes - that is a great catch. We definitely need to fill this gap.
Much thanks @mlichvar for pointing us this problem.
I'm leaving this issue open till we solve it.

@mmichaliINTC
Copy link
Contributor

Hi @mlichvar - do you think that might be a good approach?
#15

@mlichvar
Copy link
Contributor Author

Yes, that looks good to me. Thanks.

@mmichaliINTC
Copy link
Contributor

0.9.1 is released with the fix, should be working fine now.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants