Use nanosleep on Linux in atomic_backoff when spinning for a long time. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to significantly reduce CPU system time while spinning, as apparently nanosleep deschedules the thread for a longer time. See oneapi-src#105. On the test presented there, this patch offers to reduce CPU system time by 25-30%. On a real world application that test is based on this patch offers ~10% improvement. However, the change causes test_task_arena failures, as described in oneapi-src#104.
|
I've created an updated PR #327 that is rebased against oneTBB code base. I'm not closing this PR for reference and in case if anyone needs this functionality for older TBB releases. However, you can close it if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to significantly reduce CPU system time while spinning, as
apparently nanosleep deschedules the thread for a longer time.
See #105. On the test presented there,
this patch offers to reduce CPU system time by 25-30%. On a real world
application that test is based on this patch offers ~10% improvement.
However, the change causes test_task_arena failures, as described in
#104.