-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always warn on cpu fallback #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dvrogozh , do you have the privilege to add a reviewer? |
No, unfortunately I do not. |
@EikanWang @fengyuan14. Some of |
Retrigger the preci. Skipped cases failed due to PyTorch daily update. |
@fengyuan14 : tests are still failing. Should this be retriggered again? |
|
@fengyuan14 : Ok, so there are some tests in pytorch which don't allow warnings. However, the tests which fail actually run few basic ops - in a way someone might consider that these ops should not fail and should run on appropriate device. I.e. actually someone might consider that these tests are actually broken and incorrectly report status. There are few ways to proceed with this PR:
I need your opinions on this. From my side, I will check tomorrow which ops are not implemented. As of now I checked only 1 test:
|
I prefer the first option. Looks there won't be too many efforts to take. And |
As far as I can tell from the log, we have 2 tests failing, both requiring same op:
|
Fixes: #262, pytorch/pytorch#126488
5bf9e0c ("Register operator's implementation lazily") disabled warnings printout on explicit CPU fallback. I believe that users and customers will benefit from these warnings in all the cases. Note that "explicit fallback" seems to be some internal intel classification term for supported/unsupported operations unlikely known to others. Thus, non-intel users will likely care for cpu fallback in general regardless of its type. This PR adds warning back for all CPU fallback cases. We did discuss in pytorch/pytorch#126488 that maybe printout in Release build might not be needed - I am thinking otherwise and added printout for all the build modes. Let's discuss this in the PR review.
CC: @gujinghui @EikanWang @fengyuan14 @guangyey @jgong5