[Model/Layer] New forward to support CB (CommonDecoder->DecoderBlock->DecoderLayer->Attention/MLP) #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abenmao @Duyi-Wang pls help to review. |
Duyi-Wang
reviewed
May 8, 2024
| @@ -265,10 +254,6 @@ class CommonDecoder : public AbstractDecoder { | |||
| if (this->attnMask) free(this->attnMask); | |||
|
|
|||
| delete this->predictor; | |||
|
|
|||
There was a problem hiding this comment.
Free the decoderBlock here?
src/layers/decoder_block.h
Outdated
| @@ -0,0 +1,348 @@ | |||
| // Copyright (c) 2023 Intel Corporation | |||
src/layers/decoder_block.h
Outdated
| totInSeqLen += seqs[i]->getInputSeqLen(); | ||
| } | ||
|
|
||
| kvCacheMgr.prepareCache(seqIDs); |
There was a problem hiding this comment.
I prefer to prepare KVCache at a high level api.
We can assume all seqs' KVCache is ready.
There was a problem hiding this comment.
commented and added TODO
Duyi-Wang
pushed a commit
that referenced
this pull request
May 15, 2024
…>DecoderLayer->Attention/MLP) (#375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.