Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mjpeg_streamer customizeable #72

Closed
mloit opened this issue Apr 30, 2018 · 4 comments
Closed

Make mjpeg_streamer customizeable #72

mloit opened this issue Apr 30, 2018 · 4 comments

Comments

@mloit
Copy link

mloit commented Apr 30, 2018

It would be helpful having the systemd service script invoke a shell script, instead of streamer directly, and have the shell script somewhere accessible for OctoPrint to update through the UI, so that people can customize easily based on their webcam.

@goeland86 goeland86 self-assigned this May 7, 2018
@goeland86 goeland86 removed their assignment May 7, 2018
@goeland86
Copy link
Member

goeland86 commented May 7, 2018

Agreed, but at this point I've got too little time to take a crack at it for 2.1.2

@eliasbakken eliasbakken added this to the Refactor v3.0.2 milestone Sep 3, 2021
@eliasbakken
Copy link

mjpeg.service fails on Refactor Recore, so we should find a solution to this.

@goeland86
Copy link
Member

@eliasbakken it only fails if no webcam is plugged in. Just so we're clear. We could modify the systemd script to depend on /dev/video0?

@eliasbakken
Copy link

The OP is requesting a way to customize certain things, I imagine that is resolution etc. There are ways to fix this in OctoPrint using a combinatition of plugins etc. but it is not a very elegant solution. I think a better way would be to make a plugin for OctoPrint. That could be a solution for the future, but I think for now we should be satisfied with changing the settings by editing the service file directly.

There is a PR waiting to be merged that causes the service to not fail if there is no webcam present on Recore, I think that will be enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants