Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize auto scaler #1169

Merged

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

Optimize scaler.

Why are the changes needed?

For better code structure and debugging.

Does this PR introduce any user-facing change?

Nope.

How was this patch tested?

UT.

@BalaBalaYi BalaBalaYi added the enhancement New feature or request label Jun 26, 2024
@BalaBalaYi BalaBalaYi requested a review from samplise June 26, 2024 09:07
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.68%. Comparing base (0c18cc5) to head (0b8f195).

Files Patch % Lines
dlrover/python/master/node/job_auto_scaler.py 76.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   79.67%   79.68%           
=======================================
  Files         210      210           
  Lines       18681    18687    +6     
=======================================
+ Hits        14885    14891    +6     
  Misses       3796     3796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please add a little more details about each pr in the future.

@samplise samplise merged commit 4b9dc4e into intelligent-machine-learning:master Jun 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants