Merge pull request #35 from intelligentplant/v2-working

Stop TagValueBuilder.WithError from setting bad quality for null or white space error messages
intelligentplant · Nov 26, 2020 · cc6bf07 · cc6bf07
2 parents a9543d4 + 06d7bfb
commit cc6bf07
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/DataCore.Adapter/RealTimeData/TagValueBuilder.cs b/src/DataCore.Adapter/RealTimeData/TagValueBuilder.cs
@@ -218,11 +218,14 @@ public class TagValueBuilder {
         ///   The updated <see cref="TagValueBuilder"/>.
         /// </returns>
         /// <remarks>
-        ///   The status of the value will also be set to <see cref="TagValueStatus.Bad"/>.
+        ///   If <paramref name="error"/> is not <see langword="null"/> or white space, the status 
+        ///   of the value will also be set to <see cref="TagValueStatus.Bad"/>.
         /// </remarks>
         public TagValueBuilder WithError(string? error) {
             _error = error;
-            _status = TagValueStatus.Bad;
+            if (!string.IsNullOrWhiteSpace(error)) {
+                _status = TagValueStatus.Bad;
+            }
             return this;
         }