Poll in batches of no more than 100 tags (#350)

intelligentplant · Aug 28, 2023 · cf65bcf · cf65bcf
1 parent 551ff31
commit cf65bcf
Showing 1 changed file with 23 additions and 10 deletions.
diff --git a/src/DataCore.Adapter/RealTimeData/PollingSnapshotTagValuePush.cs b/src/DataCore.Adapter/RealTimeData/PollingSnapshotTagValuePush.cs
@@ -174,17 +174,30 @@ public class PollingSnapshotTagValuePush : SnapshotTagValuePush {
                 return;
             }
 
-            await foreach (var val in _readSnapshotFeature.ReadSnapshotTagValues(
-                new DefaultAdapterCallContext(),
-                new ReadSnapshotTagValuesRequest() {
-                    Tags = tags
-                }, cancellationToken
-            ).ConfigureAwait(false)) {
-                if (val == null) {
-                    continue;
+            const int MaxTagsPerRequest = 100;
+            var page = 0;
+            var @continue = false;
+
+            do {
+                ++page;
+                var pageTags = tags.Skip((page - 1) * MaxTagsPerRequest).Take(MaxTagsPerRequest).ToArray();
+                if (pageTags.Length == 0) {
+                    break;
                 }
-                await ValueReceived(val, cancellationToken).ConfigureAwait(false);
-            }
+                @continue = pageTags.Length == MaxTagsPerRequest;
+
+                await foreach (var val in _readSnapshotFeature.ReadSnapshotTagValues(
+                    new DefaultAdapterCallContext(),
+                    new ReadSnapshotTagValuesRequest() {
+                        Tags = tags
+                    }, cancellationToken
+                ).ConfigureAwait(false)) {
+                    if (val == null) {
+                        continue;
+                    }
+                    await ValueReceived(val, cancellationToken).ConfigureAwait(false);
+                }
+            } while (@continue);
         }