Implement HTTP endpoints using Minimal APIs #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a .NET 7 class library that registers the HTTP API using Minimal API routing instead of MVC. The long-term goal is for this library to replace the MVC library to simplify OpenAPI generation and improve performance compared to MVC, especially since the momentum within ASP.NET Core seems to be towards Minimal APIs rather than API controllers in MVC.
Now uses new Minimal API class library instead of MVC controllers
Moves the System.Diagnostics.DiagnosticSource reference from DataCore.Adapter.OpenTelemetry to DataCore.Adapter.Abstractions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #264.
Instead of re-writing the MVC project to use Minimal APIs, a new
DataCore.Adapter.AspNetCore.MinimalApiproject has been added. This project targets .NET 7.0 due to the more limited capabilities of Minimal APIs in .NET 6.0.The HTTP proxy is now used to test both the MVC endpoints and the Minimal API endpoints when the unit tests project targets .NET 7.0.