Subscription performance improvements #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PatternMatchingExtensions.Like(string?, string)` will perform a simple `string.Equals` call if the match pattern does not actually contain any wildcard characters (`*`, `?`). All overloads of `PatternMatchingExtensions.Like` will now return `false` if the string to match against the pattern is null.
`SubscriptionManagerOptions.ChannelCapacity` is now 10 000 by default instead of 100.
`SubscriptionChannel` now uses `RunIngressLoop`'s cancellation token in conjunction with `ChannelReader<T>.TryRead` for faster cancellation detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes designed to improve the performance of real-time data and event subscriptions:
PatternMatchingExtensions.Likeimprovements to prevent creation ofRegexinstances if a pattern does not actually contain any wildcards.