Add key/value store write buffer helper #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`KeyValueStoreWriteBuffer` is a new helper class that replicates (and extends) the write buffering in the SQLite key/value store so that the buffering can be used in any implementation that requires it. In addition to periodic flushing of pending changes, `KeyValueStoreWriteBuffer` also allows automatic flushing to be configured when the number of pending changes exceeds a limit or the total byte size or the pending changes exceeds a limit. The SQLite-based store has been rewritten to use `KeyValueStoreWriteBuffer` instead of its own implementation.
Instead of setting a `_useBackgroundFlush` field to specify if a write buffer is being used, adds a new `UseWriteBuffer` property that returns `true` if the `_writeBuffer` is not `null`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
KeyValueStoreWriteBufferclass toDataCore.Adapter.Abstractions.KeyValueStoreWriteBufferallowsIKeyValueStoreimplementations to put pending write and delete actions in an in-memory buffer that invokes a callback to flush the pending changes on a periodic basis, or if the number of pending changes or the overall byte size of the changes hit their respective limits.The SQLite-based store has been modified to replace its own write buffer with
KeyValueStoreWriteBufferand the file system-based store can now use the same write buffer.