Fix issue #905, #790 and duplicative modules when loading via dub #918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also noticed that
visitDeclaratorIdentifierList
was missing when I built it, I stubbed it out locally but that isn't right.It does concern me that we are doing more work than required and I have to later on remove modules when loading via dub.
I couldn't work out what introduced it, but anyway now it has the source directory set without the dialog from the exception.