Introduce a submodule for the plugin implementation #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
etienne02
force-pushed
the
split-submodules
branch
from
cc21382
to
337749c
Compare
This allow to break the current circular dependency between dub and the core plugin. A long term plan is to split the core implementation into more submodules, implementation that need to remain private (for the plugin only) and the api that is shared and can be used by other modules. A more complex architecture (with more isolated submodules) can be made in the future but the goal of this commit is to be able to upgrade intellij-gradle plugin.
etienne02
force-pushed
the
split-submodules
branch
from
337749c
to
6e663bd
Compare
SingingBush
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to break the current circular dependency between dub and the core plugin. A long term plan is to split the core implementation into more submodules, implementation that need to remain private (for the plugin only) and the api that is shared and can be used by other modules. A more complex architecture (with more isolated submodules) can be made in the future but the goal of this commit is to be able to upgrade intellij-gradle plugin.
Replace #927 as it only move the xml file. An incremental migration to multimodule will be done in the future