Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract function/method #2183

Open
18 of 20 tasks
Undin opened this issue Jan 10, 2018 · 1 comment
Open
18 of 20 tasks

Extract function/method #2183

Undin opened this issue Jan 10, 2018 · 1 comment
Labels
feature meta Top level/tracking issue that group collections of related issues subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc. subsystem::refactoring Issues related to refactorings

Comments

@Undin
Copy link
Member

Undin commented Jan 10, 2018 •
edited by dima74

Meta-issue about "extract function/method" feature

  • Extract function/method arguments
  • Mutability
  • Generic types
  • Pass references if possible
  • Improve dialog UI Improve "extract function" dialog #2186
  • When extracting method, use Self:: instead of fully qualified name if possible (when extracted method is static)

Related issues:
@Undin Undin added the subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc. label Jan 10, 2018
@Undin Undin added the feature label Feb 4, 2018
@Undin Undin mentioned this issue Mar 11, 2018
Closed
3 tasks
@gilescope
Copy link

+1 to Pass references if possible. I guess one might be able to detect if that was the last usage of the parameter and if so pass without a reference. Feels like there should be a checkbox "prefer references" on the refactoring dialog box (with it defaulted to checked). Amazing how well extract method works btw, aside from references by default it did a great job. (Keep up the excellent work!)

@Undin Undin added the meta Top level/tracking issue that group collections of related issues label May 7, 2018
@Kobzol Kobzol mentioned this issue May 10, 2019
Merged
bors bot added a commit that referenced this issue May 20, 2019
@bors @Kobzol
Merge #3827
84ba447 
3827: REF: improve extract method dialog UI r=ortem a=Kobzol

This PR attempts to improve the Extract method dialog UI.
Related issues: #2186, #2183

Right now it fixes an exception that was thrown when an invalid name was used for the name of the function (#1934).

I also tried to use a simple text field instead of the dropdown list if there are no suggestions to offer, however `NameSuggestionsField` always returns true from `hasSuggestions()` method (which is caused by the way it's used in the dialog), so I'm not sure how to recognize when there are no suggestions (maybe use a different component altogether)?

Co-authored-by: Jakub Beránek <berykubik@gmail.com>
@artemmukhin artemmukhin added the subsystem::refactoring Issues related to refactorings label Feb 6, 2020
@artemmukhin artemmukhin mentioned this issue Sep 20, 2021
Closed
@artemmukhin artemmukhin mentioned this issue Oct 18, 2021
Merged
bors bot added a commit that referenced this issue Oct 18, 2021
@bors @dima74
Merge #7945
8297ef7 
7945: REF: Always use `Self::` when extracting static method r=ortem a=dima74

This will create a slightly more concise method call.

Requested by `@krojew` in #7232
Part of #2183

changelog: Use `Self::` instead of fully qualified name for method call when extracting static method


Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature meta Top level/tracking issue that group collections of related issues subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc. subsystem::refactoring Issues related to refactorings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gilescope @Undin @artemmukhin