-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda syntax completion #3830
Labels
Comments
This was referenced Jul 7, 2021
bors bot
added a commit
that referenced
this issue
Jul 19, 2021
7551: COMP: Use suggestedNames() in lambda completion r=vlad20012 a=ozkriff This PR attempts to improve lambda completion by re-using the existing `RsExpr.suggestedNames()` code for initial parameter names. Related to #3830 Based on #7487 changelog: improve lambda's parameter name suggestion Co-authored-by: Andrey Lesnikov <Andrey.Lesnikov@jetbrains.com>
bors bot
added a commit
that referenced
this issue
Jul 23, 2021
7482: COMP: fix RsCompletionTestFixtureBase::checkCompletion r=vlad20012 a=Kobzol While working on #3830, I noticed that the function `RsCompletionTestBase::checkCompletion` does not behave correctly. If no testmark is passed to the function, it basically won't do anything, therefore the test will always succeed. I changed `checkCompletion` so that it actually does something even without a testmark. It now also throws an error if the passed lookup string is not found. There were a few tests that used `checkCompletion` without a testmark, so they passed even though they were actually failing. I tried to fix them. Co-authored-by: Jakub Beránek <berykubik@gmail.com>
bors bot
added a commit
that referenced
this issue
Jul 23, 2021
7482: COMP: fix RsCompletionTestFixtureBase::checkCompletion r=vlad20012 a=Kobzol While working on #3830, I noticed that the function `RsCompletionTestBase::checkCompletion` does not behave correctly. If no testmark is passed to the function, it basically won't do anything, therefore the test will always succeed. I changed `checkCompletion` so that it actually does something even without a testmark. It now also throws an error if the passed lookup string is not found. There were a few tests that used `checkCompletion` without a testmark, so they passed even though they were actually failing. I tried to fix them. Co-authored-by: Jakub Beránek <berykubik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be great, if closure syntax (with pipes) can be completed.
E. g. for:
Here I expect completion item
|i| <caret>
.Name suggestion already implemented for introduce variable refactoring.
Also, after completion we can suggest change parameter's name.
The text was updated successfully, but these errors were encountered: