Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACT | CLion | Weird make pub suggestion at the end of Code blocks #6577

Closed
DzenanJupic opened this issue Dec 29, 2020 · 0 comments · Fixed by #6580
Closed

ACT | CLion | Weird make pub suggestion at the end of Code blocks #6577

DzenanJupic opened this issue Dec 29, 2020 · 0 comments · Fixed by #6580
Assignees
Labels
bug subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc.

Comments

@DzenanJupic
Copy link

Environment

  • IntelliJ Rust plugin version: 0.3.138.3572-203
  • Rust toolchain version: 1.51.0-nightly (0b644e419 2020-12-26) x86_64-pc-windows-msvc
  • IDE name and version: CLion 2020.3 (CL-203.5981.166)
  • Operating system: Windows 10 10.0
  • Macro expansion engine: new
  • Name resolution engine: old

Problem description

When the cursor is at the end of a fn, impl, or trait block, there are two new context actions make pub and make pub(crate):
image

Which, when selected, append a pub or pub(crate) to the end of the code block:
image

I think the intended behaviour is to make the function public, like when you place the cursor at the beginning of the function:
image

Even though in this case, this also makes no sense, since deserialize is a trait function and therefore cannot have a visibility modifier.

@Kobzol Kobzol added subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc. bug labels Dec 29, 2020
@bors bors bot closed this as completed in ac720c5 Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants