Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT: do not offer ChangeVisibilityIntention in trait impl blocks #6580

Merged
merged 1 commit into from Jan 16, 2021
Merged

INT: do not offer ChangeVisibilityIntention in trait impl blocks #6580

merged 1 commit into from Jan 16, 2021

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 29, 2020

Fixes: #6577

changelog: Fix ChangeVisibilityIntention so that it is not offered in trait impl blocks.

@Kobzol Kobzol added the fix Pull requests that fix some bug(s) label Dec 29, 2020
@Kobzol Kobzol added this to In Progress in To test via automation Dec 29, 2020
@vlad20012
Copy link
Member

👍 Thanks!
bors r+

@Undin Undin added this to the v140 milestone Jan 16, 2021
@bors
Copy link
Contributor

bors bot commented Jan 16, 2021

Build succeeded:

@bors bors bot merged commit ac720c5 into intellij-rust:master Jan 16, 2021
To test automation moved this from In Progress to Test Jan 16, 2021
@Kobzol Kobzol deleted the fix-change-visibility-int-availability branch January 16, 2021 12:34
@lancelote lancelote moved this from Test to Done in To test Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 Awaiting requested review from vlad20012

Assignees
No one assigned
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v140
Development

Successfully merging this pull request may close these issues.

ACT | CLion | Weird make pub suggestion at the end of Code blocks
3 participants
@Kobzol @vlad20012 @Undin