New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support let-else statement for CFG #10215
Conversation
@White-Green Thank you, and welcome to IntelliJ Rust! As a first-time contributor, you can add your username to Could you please clarify what kind of issue you have with tests? Maybe we can help. Also, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please handle let-else syntax in org.rust.lang.core.dfa.ExprUseWalker#walkLet
and add the corresponding test cases to RsUnreachableCodeInspectionTest
Note, we don't collect contributors' usernames anymore since we don't need to check CLA |
@ortem Thank you for pointing out the missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment.
Before we merge it, please squash your commits into one and force-push it
@White-Green Thank you again, and welcome to IntelliJ Rust contributors! bors r+ |
Build succeeded: |
fix: #9681 (cc: @ortem)
Follow-up for #7798
This pull request addresses issue #9681 by correctly handling the else block of let-else statements in the construction of the ControlFlowGraph.
Due to issues with my environment, not all tests could be executed. I apologize if any failures occurred.
changelog: Fix false-positive detection of unreachable code with
let else
syntax