Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT: Fix StackOverflowError in Invert if condition intention #10260

Merged
merged 1 commit into from Mar 18, 2023
Merged

INT: Fix StackOverflowError in Invert if condition intention #10260

merged 1 commit into from Mar 18, 2023

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Mar 16, 2023

Fixes #10251

changelog: Fix Invert if condition intention when there is another if after current one

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Mar 16, 2023
@intellij-rust-bot intellij-rust-bot added this to In Progress in To test Mar 16, 2023
vlad20012
vlad20012 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function canBeStmtWithoutSemicolon seems unused now

@dima74 dima74 force-pushed the diralik/fix-invert-if-intention branch from e09cd4d to c3a0d5f Compare March 17, 2023 21:23
@dima74
Copy link
Member Author

dima74 commented Mar 17, 2023

bors r=vlad20012

@bors
Copy link
Contributor

bors bot commented Mar 18, 2023

Build succeeded:

@bors bors bot merged commit 5f39567 into master Mar 18, 2023
32 checks passed
To test automation moved this from In Progress to Test Mar 18, 2023
@bors bors bot deleted the diralik/fix-invert-if-intention branch March 18, 2023 00:58
@github-actions github-actions bot added this to the v191 milestone Mar 18, 2023
@neonaot neonaot self-assigned this Mar 21, 2023
@neonaot neonaot moved this from Test to Done in To test Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees

@vlad20012 vlad20012

@neonaot neonaot

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v191
Development

Successfully merging this pull request may close these issues.

StackOverflowError when invoking Invert if condition intention
3 participants
@dima74 @vlad20012 @neonaot