Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANN: Show E0133 when accessing union field outside unsafe block #10268

Merged
merged 1 commit into from Mar 28, 2023
Merged

ANN: Show E0133 when accessing union field outside unsafe block #10268

merged 1 commit into from Mar 28, 2023

Conversation

konrad-sz
Copy link
Collaborator

Show E0133 when accessing union field outside unsafe block

@konrad-sz konrad-sz linked an issue Mar 18, 2023 that may be closed by this pull request
E0133 (Unsafe code outside unsafe block) is not detected when accessing to union field #10245
Closed
@vlad20012 vlad20012 self-assigned this Mar 21, 2023
vlad20012
vlad20012 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btw you can add unsafe highlighting (when it's not an error) for union field access in the same annotator
image

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 28, 2023

Build succeeded:

@bors bors bot merged commit f4b62cf into master Mar 28, 2023
32 checks passed
@bors bors bot deleted the konrad-sz/E0133 branch March 28, 2023 18:42
@github-actions github-actions bot added this to the v192 milestone Mar 28, 2023
@intellij-rust-bot intellij-rust-bot added this to Test in To test Mar 29, 2023
@neonaot neonaot self-assigned this Mar 31, 2023
@neonaot
Copy link
Member

neonaot commented Mar 31, 2023

Hi!
It's not a problem of this PR, but a possible improvement for E0133: #10312

@neonaot neonaot moved this from Test to Done in To test Mar 31, 2023
@vlad20012 vlad20012 mentioned this pull request Apr 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees

@vlad20012 vlad20012

@neonaot neonaot

Labels
feature
Projects
To test
  
Done
Milestone
v192
Development

Successfully merging this pull request may close these issues.

E0133 (Unsafe code outside unsafe block) is not detected when accessing to union field
3 participants
@konrad-sz @neonaot @vlad20012