T: run tests with JUnit4 #10388
Merged
T: run tests with JUnit4 #10388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
added
the
internal
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #10277 we run some tests (descendants of
RsIntentionTestBaseclass) using JUnit4, but we still run most of the tests using JUnit3. I'd want to put all tests in line in order to avoid possible differences in the framework behavior and also to benefit from JUnit4 features like the@Ignoreannotation.JUnit4 basically implies using
@Testannotations to mark a test function, but I managed to avoid it by using a custom test runner (I don't want to bring> 10000changes in> 600files right now).If everything goes well, this PR won't affect anything (since you can write and run tests as usual).
changelog: migrate tests to JUnit4