Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdlib deps fetching on 1.72.0-beta #10706

Merged
merged 1 commit into from Jul 17, 2023

Conversation

vlad20012
Copy link
Member

Starting from 1.72.0-beta.1 there is a nightly Cargo feature usage in the stdlib:
cargo-features = ["public-dependency"]
So we need to pass RUSTC_BOOTSTRAP=1 during loading the stdlib workspace.

changelog: Fix stdlib deps fetching on 1.72.0-beta

@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Jul 17, 2023
@vlad20012 vlad20012 self-assigned this Jul 17, 2023
@vlad20012
Copy link
Member Author

bors r+

@intellij-rust-bot intellij-rust-bot added this to In Progress in To test Jul 17, 2023
@github-actions
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.1.5
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@bors
Copy link
Contributor

bors bot commented Jul 17, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 220e07e into master Jul 17, 2023
8 of 15 checks passed
To test automation moved this from In Progress to Test Jul 17, 2023
@bors bors bot deleted the fix-stdlib-deps-fetching-on-beta-1.72 branch July 17, 2023 23:41
@github-actions github-actions bot added this to the v200 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Test
Development

Successfully merging this pull request may close these issues.

None yet

1 participant