Enable RsReferenceCodeVisionProvider for top-level items
#10763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
Merge conflict. |
Enable it for items except: - an associated item (an impl/trait member) - a struct field - a macro declaration - an enum variant Usage code vision can be enabled for these elements using `org.rust.code.vision.usage.slow` registry option [skip ci]
vlad20012
force-pushed
the
enable-usages-code-vision-for-top-level-items
branch
from
ac588c4
to
4d1fdea
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider was initially added in #9927.
Here I enable usages Code Vision for Rust items except:
Usage code vision can be enabled for these elements using
org.rust.code.vision.usage.slowregistry option.For other items Reference Search does not use type inference and hence it should work fast.
I additionally adjusted
RsReferenceImpl.isReferenceTo()to ensure it does not touch type inference in such cases.changelog: Enable Usages Code Vision hints for some top-level items