Borrow checker (move analysis) #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmukhin
force-pushed
the
borrow-checker-move
branch
6 times, most recently
from
1725dd3
to
5534ade
Compare
artemmukhin
force-pushed
the
borrow-checker-move
branch
7 times, most recently
from
b9edd14
to
1474182
Compare
artemmukhin
force-pushed
the
borrow-checker-move
branch
2 times, most recently
from
638d722
to
61c13f4
Compare
vlad20012
reviewed
Oct 15, 2018
src/main/kotlin/org/rust/ide/inspections/fixes/DeriveCopyFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/fixes/DeriveCopyFix.kt
Outdated
Show resolved
Hide resolved
| val mutCat = lpKind.mutCategory | ||
|
|
||
| // Moving/assigning one union field automatically moves/assigns all its fields | ||
| union.namedFields |
There was a problem hiding this comment.
This fragment isn't covered by tests
| } | ||
|
|
||
| pathAssignments.forEach { assignment -> | ||
| killMoves(assignment.path, assignment.element, Execution, dfcxMoves) |
There was a problem hiding this comment.
This fragment isn't covered by tests
| fields.mapNotNull { it.expr }.forEach { consumeExpr(it) } | ||
| if (withExpr == null) return | ||
|
|
||
| val withCmt = mc.processExpr(withExpr) |
There was a problem hiding this comment.
This fragment isn't covered by tests
| val lpElement = extend.lpElement | ||
|
|
||
| if (lpElement is Interior.Field) { | ||
| if (baseLoanPath.ty.isAdtWithDestructor) { |
There was a problem hiding this comment.
This fragment isn't covered by tests
| is Interior.Index -> cmt | ||
|
|
||
| is Downcast -> { | ||
| val base = category.cmt |
There was a problem hiding this comment.
This fragment isn't covered by tests
|
And maybe we can write more tests? And if so, we can move these tests to a separate file |
artemmukhin
force-pushed
the
borrow-checker-move
branch
2 times, most recently
from
220a00d
to
b7006be
Compare
artemmukhin
changed the title
artemmukhin
force-pushed
the
borrow-checker-move
branch
4 times, most recently
from
fee8a2c
to
ed5611a
Compare
vlad20012
reviewed
Oct 17, 2018
vlad20012
reviewed
Oct 17, 2018
vlad20012
reviewed
Oct 17, 2018
artemmukhin
force-pushed
the
borrow-checker-move
branch
5 times, most recently
from
fdc117e
to
d0942fc
Compare
artemmukhin
force-pushed
the
borrow-checker-move
branch
8 times, most recently
from
de12ed7
to
a40061e
Compare
artemmukhin
force-pushed
the
borrow-checker-move
branch
from
a40061e
to
cda38a2
Compare
|
I think we can merge it. Objections? No? Ok, let's go! |
|
🤔 Looks like bors is crashed |
|
bors r- |
|
Let's try again |
bors bot
added a commit
that referenced
this pull request
Oct 19, 2018
2810: Borrow checker (move analysis) r=vlad20012 a=ortem - Introduce `DataFlowContext` providing `GEN` and `KILL` sets and propagation; - Introduce initial part of borrow checker providing move analysis; - Add `Use of moved value` and `Cannot move` error messages to `RsBorrowCheckerInspection`; - Add `DeriveCopyFix` for such errors.  Co-authored-by: ortem <ortem00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFlowContextprovidingGENandKILLsets and propagation;Use of moved valueandCannot moveerror messages toRsBorrowCheckerInspection;DeriveCopyFixfor such errors.