Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACT: Try to group auto-inserted use item with existing ones by last component #3405

Merged
merged 2 commits into from
Feb 24, 2019
Merged

ACT: Try to group auto-inserted use item with existing ones by last component #3405

merged 2 commits into from
Feb 24, 2019

Conversation

mchernyavsky
Copy link
Member

Closes #3403.

@vlad20012
Copy link
Member

Really is should be done via "Optimize imports" action.

Also, should it be optional?

@Undin
Copy link
Member

Undin commented Feb 15, 2019 •
edited

Really is should be done via "Optimize imports" action.

Looks like no. "Optimize import" action usually reorders imports, removes unused, etc. I think it's unexpected during completion. For example, kotlin implementation of completion from index/"auto import" quick fix just insert new import item without additional actions

@vlad20012
Copy link
Member

Comments above use items should be preserved:
peek 2019-02-23 22-56

@mchernyavsky
Copy link
Member Author

Fixed.

@vlad20012
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Feb 24, 2019
@bors
Merge #3405
f763ee3 
3405: ACT: Try to group auto-inserted use item with existing ones by last component r=vlad20012 a=mchernyavsky

Closes #3403.

Co-authored-by: mchernyavsky <chemike47@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 24, 2019

Build succeeded

@bors bors bot merged commit 41543c3 into master Feb 24, 2019
@bors bors bot deleted the group-use-items branch February 24, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin left review comments

@vlad20012 vlad20012 vlad20012 left review comments

Assignees

@vlad20012 vlad20012

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mchernyavsky @vlad20012 @Undin