Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ReadWriteAccessDetector #3819

Merged
merged 1 commit into from May 14, 2019
Merged

Implement ReadWriteAccessDetector #3819

merged 1 commit into from May 14, 2019

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented May 9, 2019 •
edited

This enables read/write categorization of variable usages:

image
(look at red/green icons next to each usage)

@mchernyavsky mchernyavsky self-assigned this May 10, 2019
mchernyavsky
mchernyavsky approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 13, 2019
@bors @vlad20012
Merge #3819
c77a6f1 
3819: Implement ReadWriteAccessDetector r=mchernyavsky a=vlad20012

This enables read/write categorization of variable usages:

![image](https://user-images.githubusercontent.com/3221931/57468786-d457f480-728d-11e9-97f2-47fed76d5aa7.png)
(look at red/green icons next to each usage)


Co-authored-by: vlad20012 <beskvlad@gmail.com>
@mchernyavsky
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 14, 2019
@bors @vlad20012
Merge #3819
8f1a95f 
3819: Implement ReadWriteAccessDetector r=mchernyavsky a=vlad20012

This enables read/write categorization of variable usages:

![image](https://user-images.githubusercontent.com/3221931/57468786-d457f480-728d-11e9-97f2-47fed76d5aa7.png)
(look at red/green icons next to each usage)


Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 14, 2019

Build succeeded

@bors bors bot merged commit aa1b044 into intellij-rust:master May 14, 2019
@mchernyavsky mchernyavsky added this to the v98 milestone May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
feature
Projects
None yet
Milestone
v98
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlad20012 @mchernyavsky