Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANN: allow to autoimport traits in UFCS calls #4083

Merged
merged 2 commits into from Sep 2, 2019
Merged

ANN: allow to autoimport traits in UFCS calls #4083

merged 2 commits into from Sep 2, 2019

Conversation

vlad20012
Copy link
Member

No description provided.

@Undin Undin added this to In Progress in To test via automation Aug 13, 2019
@Undin Undin added the fix Pull requests that fix some bug(s) label Aug 13, 2019
Undin
Undin approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Rebase onto master, please

src/main/kotlin/org/rust/ide/inspections/import/AutoImportFix.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/ide/inspections/import/AutoImportFix.kt Outdated Show resolved Hide resolved
@mchernyavsky mchernyavsky modified the milestones: v104, v105 Aug 14, 2019
@Undin
Copy link
Member

Undin commented Aug 27, 2019

@vlad20012 ping

Undin
Undin reviewed Aug 31, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a weird commit (at least commit with non-related message to this PR) after rebase.
Maybe it's worth to squash them into a single one?

src/main/kotlin/org/rust/lang/core/types/infer/TypeInferenceWalker.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/ide/inspections/import/AutoImportFix.kt Outdated Show resolved Hide resolved
@vlad20012 vlad20012 force-pushed the autoimport-traits branch 2 times, most recently from ca9bc85 to 23fc73b Compare September 2, 2019 10:15
Undin
Undin approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Sep 2, 2019
@bors @vlad20012
Merge #4083
ba7dd1a 
4083: ANN: allow to autoimport traits in UFCS calls r=Undin a=vlad20012



Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 2, 2019

Build succeeded

@bors bors bot merged commit 5dfc204 into intellij-rust:master Sep 2, 2019
To test automation moved this from In Progress to Test Sep 2, 2019
@lancelote lancelote mentioned this pull request Sep 4, 2019
Open
@lancelote lancelote moved this from Test to Done in To test Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin approved these changes

Assignees

@Undin Undin

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v105
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vlad20012 @Undin @mchernyavsky