Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty-printers for LLDB and GDB: hashbrown's HashMap support #4107

Merged
merged 3 commits into from Jul 22, 2019
Merged

Pretty-printers for LLDB and GDB: hashbrown's HashMap support #4107

merged 3 commits into from Jul 22, 2019

Conversation

artemmukhin
Copy link
Member

@artemmukhin artemmukhin commented Jul 6, 2019 •
edited

Fixes #4005

@Undin Undin self-assigned this Jul 7, 2019
Undin
Undin reviewed Jul 10, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep formatter for old version of HashMap/HashSet. hashbrown implementation is stable only since 1.36 so I think there are a lot of users with previous Rust toolchain and I would not like to break their debugging

@artemmukhin artemmukhin changed the title Bundled pretty-printers for LLDB: hashbrown's HashMap support Pretty-printers for LLDB and GDB: hashbrown's HashMap support Jul 13, 2019
@artemmukhin
Copy link
Member Author

@Undin thanks for the observation, done!

@Undin
Copy link
Member

Undin commented Jul 15, 2019

@ortem looks like tests failed

@artemmukhin artemmukhin added this to the v102 milestone Jul 22, 2019
Undin
Undin approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 22, 2019
@bors @artemmukhin
Merge #4107
e23a32c 
4107: Pretty-printers for LLDB and GDB: hashbrown's HashMap support r=Undin a=ortem

Fixes #4005

Co-authored-by: ortem <ortem00@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 22, 2019

Build succeeded

@bors bors bot merged commit 2c05f53 into intellij-rust:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fan-tom fan-tom fan-tom left review comments

@Undin Undin Undin approved these changes

Assignees

@Undin Undin

Labels
feature
Projects
None yet
Milestone
v102
Development

Successfully merging this pull request may close these issues.

Adapt HashMap/HashSet debugger formatters to new implementation
3 participants
@artemmukhin @Undin @fan-tom