Make Toml plugin mandatory dependency of Rust plugin #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
force-pushed
the
mandatory-toml-dependency
branch
2 times, most recently
from
61bfcc3
to
835f242
Compare
It allows avoiding hack with manual collecting plugin jars into sandbox directory - now gradle does it automatically because `plugin` module depends on all other rust module. Also, now core module doesn't have unnecessary plugin dependencies. It should prevent accident usage of code from unrelated plugins that needed previously only for run task
Otherwise, test IDEA application can't find root `plugin.xml` and load the corresponding extensions
Undin
force-pushed
the
mandatory-toml-dependency
branch
from
835f242
to
15177e7
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.