Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANN: detect invalid usages of impl Trait(E0562, E0666, E0667) #4140

Merged
merged 1 commit into from Jul 15, 2019

Conversation

rrevenantt
Copy link
Contributor

No description provided.

@Undin Undin added the feature label Jul 13, 2019
@mchernyavsky mchernyavsky self-assigned this Jul 13, 2019
@mchernyavsky mchernyavsky added this to the v102 milestone Jul 13, 2019
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

bors bot added a commit that referenced this pull request Jul 15, 2019
4140: ANN: detect invalid usages of `impl Trait`(E0562, E0666, E0667) r=mchernyavsky a=rrevenantt

 

Co-authored-by: Konstantin Anisimov <rrevenantt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 15, 2019

Build failed

@mchernyavsky
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jul 15, 2019
3731: RUN: Support doc-tests by test runner r=Undin a=mchernyavsky

Fixes #3707. Fixes #3860.

Fixes:
```
java.lang.Throwable: [Cargo Test]: Illegal nodeId: TestSuiteStartedEvent{name='0', id='0', parentId='0', locationUrl='cargo:test://0', running=true}
	at com.intellij.openapi.diagnostic.Logger.error(Logger.java:145)
	at com.intellij.execution.testframework.sm.runner.GeneralTestEventsProcessor.logProblem(GeneralTestEventsProcessor.java:323)
	at com.intellij.execution.testframework.sm.runner.GeneralTestEventsProcessor.logProblem(GeneralTestEventsProcessor.java:309)
	at com.intellij.execution.testframework.sm.runner.GeneralIdBasedToSMTRunnerEventsConvertor.validateAndGetNodeId(GeneralIdBasedToSMTRunnerEventsConvertor.java:375)
	at com.intellij.execution.testframework.sm.runner.GeneralIdBasedToSMTRunnerEventsConvertor.findNode(GeneralIdBasedToSMTRunnerEventsConvertor.java:382)
	at com.intellij.execution.testframework.sm.runner.GeneralIdBasedToSMTRunnerEventsConvertor.doStartNode(GeneralIdBasedToSMTRunnerEventsConvertor.java:120)
	at com.intellij.execution.testframework.sm.runner.GeneralIdBasedToSMTRunnerEventsConvertor.onSuiteStarted(GeneralIdBasedToSMTRunnerEventsConvertor.java:113)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter.fireOnSuiteStarted(OutputToGeneralTestEventsConverter.java:279)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter.access$100(OutputToGeneralTestEventsConverter.java:30)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter$MyServiceMessageVisitor.visitTestSuiteStarted(OutputToGeneralTestEventsConverter.java:375)
	at jetbrains.buildServer.messages.serviceMessages.TestSuiteStarted.visit(TestSuiteStarted.java:32)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter.processServiceMessages(OutputToGeneralTestEventsConverter.java:126)
	at org.rust.cargo.runconfig.test.CargoTestEventsConverter.handleSuiteMessage(CargoTestEventsConverter.kt:87)
	at org.rust.cargo.runconfig.test.CargoTestEventsConverter.processServiceMessages(CargoTestEventsConverter.kt:47)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter.processConsistentText(OutputToGeneralTestEventsConverter.java:102)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter$1.onTextAvailable(OutputToGeneralTestEventsConverter.java:59)
	at com.intellij.execution.testframework.sm.runner.OutputEventSplitter.flushInternal(OutputEventSplitter.kt:149)
	at com.intellij.execution.testframework.sm.runner.OutputEventSplitter.processInternal(OutputEventSplitter.kt:94)
	at com.intellij.execution.testframework.sm.runner.OutputEventSplitter.process(OutputEventSplitter.kt:68)
	at com.intellij.execution.testframework.sm.runner.OutputToGeneralTestEventsConverter.process(OutputToGeneralTestEventsConverter.java:85)
	at com.intellij.execution.testframework.sm.SMTestRunnerConnectionUtil$2.onTextAvailable(SMTestRunnerConnectionUtil.java:213)
	at jdk.internal.reflect.GeneratedMethodAccessor37.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.intellij.execution.process.ProcessHandler$2.invoke(ProcessHandler.java:214)
	at com.sun.proxy.$Proxy22.onTextAvailable(Unknown Source)
	at com.intellij.execution.process.ProcessHandler.notifyTextAvailable(ProcessHandler.java:188)
	at org.rust.cargo.runconfig.RsKillableColoredProcessHandler.coloredTextAvailable(RsKillableColoredProcessHandler.kt:29)
	at com.intellij.execution.process.AnsiEscapeDecoder.processTextChunk(AnsiEscapeDecoder.java:99)
	at com.intellij.execution.process.AnsiEscapeDecoder.escapeText(AnsiEscapeDecoder.java:63)
	at org.rust.cargo.runconfig.RsAnsiEscapeDecoder.escapeText(RsAnsiEscapeDecoder.kt:25)
	at org.rust.cargo.runconfig.RsKillableColoredProcessHandler.notifyTextAvailable(RsKillableColoredProcessHandler.kt:25)
	at com.intellij.execution.process.BaseOSProcessHandler$SimpleOutputReader.onTextAvailable(BaseOSProcessHandler.java:179)
	at com.intellij.util.io.BaseOutputReader.sendText(BaseOutputReader.java:211)
	at com.intellij.util.io.BaseOutputReader.processInput(BaseOutputReader.java:195)
	at com.intellij.util.io.BaseOutputReader.readAvailableNonBlocking(BaseOutputReader.java:114)
	at com.intellij.util.io.BaseDataReader.readAvailable(BaseDataReader.java:77)
	at com.intellij.util.io.BaseDataReader.doRun(BaseDataReader.java:155)
	at com.intellij.util.ConcurrencyUtil.runUnderThreadName(ConcurrencyUtil.java:208)
	at com.intellij.util.io.BaseDataReader.lambda$start$0(BaseDataReader.java:61)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
```

Depends on #3734, #3735 and #3752.

4140: ANN: detect invalid usages of `impl Trait`(E0562, E0666, E0667) r=mchernyavsky a=rrevenantt

 

Co-authored-by: mchernyavsky <chemike47@gmail.com>
Co-authored-by: Konstantin Anisimov <rrevenantt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 15, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request Jul 15, 2019
4140: ANN: detect invalid usages of `impl Trait`(E0562, E0666, E0667) r=mchernyavsky a=rrevenantt

 

Co-authored-by: Konstantin Anisimov <rrevenantt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 15, 2019

@bors bors bot merged commit b0c4ca3 into intellij-rust:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants